comphead commented on code in PR #7625:
URL: https://github.com/apache/datafusion-comet/pull/7625#discussion_r4608076245


##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -3637,12 +3636,7 @@ class CometExpressionSuite extends CometTestBase with 
AdaptiveSparkPlanHelper {
       ("INT", Int.MinValue.toLong, Int.MaxValue.toLong, "ARITHMETIC_OVERFLOW"),
       ("BIGINT", Long.MinValue, Long.MaxValue, "ARITHMETIC_OVERFLOW"))) {
     test(s"ANSI integral overflow fidelity - $sqlType") {
-      val expectedErrorClass =
-        if (errorClass == "BINARY_ARITHMETIC_OVERFLOW" && !isSpark35Plus) {
-          "_LEGACY_ERROR_TEMP_2044"
-        } else {
-          errorClass
-        }
+      val expectedErrorClass = errorClass

Review Comment:
   After collapsing the `!isSpark35Plus` branch, `expectedErrorClass` is just 
an alias of `errorClass`. Use `errorClass` at the assertion on line 3675 and 
drop this `val`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to