Omkar-Wagholikar opened a new pull request, #27544:
URL: https://github.com/apache/datafusion/pull/27544
## Which issue does this PR close?
- Follow-up to #26756 / #27029.
- Part of #19795
If required, I can make a new issue for this. The changes themselves seemed
small enough to not warrant one.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
Please explain the problem you are trying to solve in terms of the
user-visible
behavior, rather than the implementation.
For example, "The code in `foo.rs` doesn't handle nulls" is a symptom of the
implementation. "COUNT(DISTINCT) returns wrong results when the column
contains
nulls" is the user-visible problem.
-->
Continuing #26756. A few optimizer rules clone an owned value then never use
it again, where moving it is simpler and avoids a copy.
The goal is cleaner code, I expect no change in the performance (no change
on benchmarks I ran on local).
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here, but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
3 call sites:
- resolve_grouping_function.rs: grouping_id_column in the early-return
branch.
- decorrelate_predicate_subquery.rs: indicator_col in
build_join_with_count_bug.
- rewrite_set_comparison.rs: comparison in the SetQuantifier::All arm.
These now move the value instead of cloning it
I found them while messing with different configs in cargo, by cargo clippy
-W clippy::redundant_clone and checked each by hand to confirm the clone is the
last use.
Almost all hits are from tests, which I have not touched (too many changes
to properly test changes to each one by hand for me)
## What is the testing strategy for this PR?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
Briefly describe how this PR is tested, and point to the specific tests you
added. For example: 'This new feature is covered by the `sqllogictest` cases
added in `foo.slt`'.
If this PR does not add tests, explain why. For example, if the change is
already covered by existing tests, please mention it.
You should also check the `codecov` bot reply on this PR to confirm the
changed code is exercised.
-->
Existing tests cover these paths. cargo test -p datafusion-optimizer and
cargo clippy -p datafusion-optimizer --all-targets -- -D warnings pass. No new
tests are required as behavior is unchanged.
## Are there any user-facing changes?
None, purely code cleanup
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]