dwsmith1983 opened a new pull request, #7678:
URL: https://github.com/apache/datafusion-comet/pull/7678

   ## Which issue does this PR close?
   
   Closes #7676.
   Closes #7677.
   
   ## Rationale for this change
   
   Two tests in `native/local`, both added in #6883, fail intermittently and 
have been evicting unrelated pull requests from the merge queue (#7556, #7464, 
#7508). Each one asserts something the code doesn't guarantee.
   
   ## What changes are included in this PR?
   
   - `partition_order_runs_at_most_the_given_number_of_partitions` compared the 
start order of two partitions that start concurrently on separate workers. It 
now checks the started set through `assert_executed_once`, which sorts, like 
the `wait_started` check a few lines above it.
   - `cancel_wakes_a_waiting_reader` asserted the plan was released as soon as 
the cancelled reader returned. An aborted partition task that hasn't run yet 
still owns its start closure, and with it the plan, until a runtime worker 
drops the task. The test now waits up to 5 seconds for the count to reach zero, 
as the other teardown checks in the crate do. 
`cancel_releases_the_graph_while_every_worker_is_busy` in `tests/bridge.rs` 
still covers the stream being dropped on the calling thread.
   
   ## How are these changes tested?
   
   Both are test changes. I forced each race and confirmed the old assertion 
failed every time with the same message as CI, while the new one passed:
   
   - a 200 ms delay before partition 0 records its start;
   - the single runtime worker held busy for 500 ms by an unrelated task.
   
   With no delay planted, fmt, clippy and the full `datafusion-comet-local` 
test suite pass, and each test passed 200 runs in a row.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to