2010YOUY01 commented on code in PR #27553:
URL: https://github.com/apache/datafusion/pull/27553#discussion_r4611398520


##########
docs/source/contributor-guide/testing.md:
##########
@@ -190,8 +190,12 @@ Fuzz testing generates random inputs and configurations, 
then checks that a prop
 
 For fuzzing unit tests, such as tests for a single operator or an internal 
utility:
 
-- If the test is small (easy to set up and takes a few seconds), keep it as a 
unit test.
-- If the test is large (requires a fuzzing driver and takes more than 10 
seconds), it should implement the [`FuzzTest` trait][fuzz framework] and run 
through the [central fuzz-test entry point]. See the [spill-pool fuzzer] for a 
reference implementation.
+The [`FuzzTest` trait][fuzz framework] simplifies fuzz tests; use it when it 
makes the test easier to implement.

Review Comment:
   The criteria should be whether `FuzzTest` trait make the implementation 
easier. The existing '< 10s test duration` is misleading.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to