rich7420 commented on PR #7194:
URL: 
https://github.com/apache/datafusion-comet/pull/7194#issuecomment-6973993165

   A few things I left out that could be follow-ups:
   
   - `regr_sxx`/`regr_syy` with interleaved keys are 6-12% slower than my first 
version that reused the variance kernel (still about 3x faster than the 
adapter). They do the least work per row, so I think the same-group check shows 
up more there. A separate loop for those two might help.
   - NULLs and `FILTER` are still checked row by row. Reading the validity bits 
64 at a time should help the half-NULL case.
   - The four scalar accumulators could share the update and merge kernels and 
drop their own composition code. That touches the path without `GROUP BY`, so I 
kept it out of this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to