tschwarzinger commented on PR #27556: URL: https://github.com/apache/datafusion/pull/27556#issuecomment-6980308524
I think there are a few things we should consider: - Is this the right place or should `GroupValuesColumn` guarantee monotonic new interned ids (if not maybe we should update the wording in the docs) - Do we keep the test for checking for the hash collision? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
