tlfua commented on PR #7568: URL: https://github.com/apache/datafusion-comet/pull/7568#issuecomment-6984921861
Thanks @comphead! Fixed both in https://github.com/tlfua/datafusion-comet/commit/a2e910a9c9f6a570a8d5a154b1a82a92882df75d: - `metadata_column_partition.sql` now uses `spark.comet.scan.icebergNative.enabled` (default `true`, so no behavior change). - I removed `spark.comet.cast.allowIncompatible` from `run_all_benchmarks.sh` rather than renaming it to `spark.comet.expression.Cast.allowIncompatible`. Comet stopped reading the old key in apache/datafusion-comet#2242, before the script was added in apache/datafusion-comet#3065, so the benchmark has never enabled incompatible casts. Renaming it would change what the benchmark measures. I also merged the latest `main`. Fork CI passed: https://github.com/tlfua/datafusion-comet/actions/runs/44329655093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
