LiaCastaneda commented on PR #27099: URL: https://github.com/apache/datafusion/pull/27099#issuecomment-6985820040
Thanks for the review Gabriel 🙇♀️ There is still some cases this PR misses, I documented them on the broader issue https://github.com/apache/datafusion/issues/27517 I agree we should find a proper solution in the long term, but I don't have the time to look into it right now :/ I think the current solution is a valid starting point since it fixes the most common struct literal bugs we've seen, and it doesn't break any plan that worked before. Also, these bugs were somehow expected, since substrait matches struct fields by position while Datafusion matches them by name (which reminds me of the schema issues we had some time ago) Alex opened a PR with an alternative approach, #27538, that we can consider as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
