kazuyukitanimura commented on code in PR #948: URL: https://github.com/apache/datafusion-comet/pull/948#discussion_r1765527194
########## native/core/benches/aggregate.rs: ########## @@ -0,0 +1,202 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License.use arrow::array::{ArrayRef, BooleanBuilder, Int32Builder, RecordBatch, StringBuilder}; + +use arrow::datatypes::{DataType, Field, Schema}; +use arrow_array::builder::{Decimal128Builder, StringBuilder}; +use arrow_array::{ArrayRef, RecordBatch}; +use arrow_schema::SchemaRef; +use comet::execution::datafusion::expressions::avg_decimal::AvgDecimal; +use comet::execution::datafusion::expressions::sum_decimal::SumDecimal; +use criterion::{criterion_group, criterion_main, Criterion}; +use datafusion::functions_aggregate::average::avg_udaf; +use datafusion::functions_aggregate::sum::sum_udaf; +use datafusion::physical_expr::PhysicalExpr; +use datafusion::physical_plan::aggregates::{AggregateExec, AggregateMode, PhysicalGroupBy}; +use datafusion::physical_plan::memory::MemoryExec; +use datafusion::physical_plan::ExecutionPlan; +use datafusion_execution::TaskContext; +use datafusion_expr::AggregateUDF; +use datafusion_physical_expr::aggregate::AggregateExprBuilder; +use datafusion_physical_expr::expressions::Column; +use futures::StreamExt; +use std::sync::Arc; +use std::time::Duration; +use tokio::runtime::Runtime; + +fn criterion_benchmark(c: &mut Criterion) { + let mut group = c.benchmark_group("aggregate"); + let num_rows = 8192; + let batch = create_record_batch(num_rows); + let mut batches = Vec::new(); + for _ in 0..10 { + batches.push(batch.clone()); + } + let partitions = &[batches]; + let c0: Arc<dyn PhysicalExpr> = Arc::new(Column::new("c0", 0)); + let c1: Arc<dyn PhysicalExpr> = Arc::new(Column::new("c1", 1)); + + let rt = Runtime::new().unwrap(); + + group.bench_function("avg_decimal_datafusion", |b| { + let datafusion_sum_decimal = avg_udaf(); + b.to_async(&rt).iter(|| { + agg_test( + partitions, + c0.clone(), + c1.clone(), + datafusion_sum_decimal.clone(), + "avg", + ) + }) + }); + + group.bench_function("avg_decimal_comet", |b| { + let comet_avg_decimal = Arc::new(AggregateUDF::new_from_impl(AvgDecimal::new( + Arc::clone(&c1), + "avg", + DataType::Decimal128(38, 10), + DataType::Decimal128(38, 10), + ))); + b.to_async(&rt).iter(|| { + agg_test( + partitions, + c0.clone(), + c1.clone(), + comet_avg_decimal.clone(), + "avg", + ) + }) + }); + + group.bench_function("sum_decimal_datafusion", |b| { + let datafusion_sum_decimal = sum_udaf(); + b.to_async(&rt).iter(|| { + agg_test( + partitions, + c0.clone(), + c1.clone(), + datafusion_sum_decimal.clone(), + "sum", + ) + }) + }); + + group.bench_function("sum_decimal_comet", |b| { + let comet_sum_decimal = Arc::new(AggregateUDF::new_from_impl(SumDecimal::new( Review Comment: do we need to use `blackbox` to avoid the optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
