coderfender commented on code in PR #360: URL: https://github.com/apache/datafusion-spark/pull/360#discussion_r4619703469
########## .ai/skills/audit-datafusion-spark-expression/SKILL.md: ########## @@ -358,12 +363,12 @@ grep -rn "TODO" crates/spark/src/function/<category>/$ARGUMENTS.rs \ ``` Wiring ANSI up is usually mechanical rather than a semantics decision. The flag -is already threaded through `ScalarFunctionArgs`, so the implementation reads -it directly: +is already threaded through `ScalarFunctionArgs`. Prefer an `EvalMode` over a +`bool` (see `CONTRIBUTING.md`), as `parse_url` and `try_parse_url` do: Review Comment: might have to make this a little bit stricter to make eval mode compulsory (at least in the top level function) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
