alexanderbianchi commented on code in PR #113:
URL:
https://github.com/apache/datafusion-iceberg/pull/113#discussion_r4622513538
##########
crates/datafusion/tests/integration_datafusion_test.rs:
##########
@@ -1035,10 +1064,13 @@ async fn test_plan_nodes_are_inspectable() ->
Result<(), Box<dyn Error>> {
.downcast_ref::<IcebergDataSource>()
.expect("an Iceberg data source");
assert_eq!(
- scan.predicate().map(ToString::to_string).as_deref(),
+ lazy_files(scan)
+ .predicate()
+ .map(ToString::to_string)
+ .as_deref(),
Some("foo1 = 1")
Review Comment:
For this PR, just tweaking these tests make sense. But they really should be
re-written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]