alamb commented on code in PR #88: URL: https://github.com/apache/datafusion-iceberg/pull/88#discussion_r4627323455
########## crates/datafusion/tests/insert_into.rs: ########## @@ -0,0 +1,491 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file Review Comment: one thing we found in datafusion is that each test binary tends to be large (e.g. datafusion is 100MB) so if you make a bunch of test binaries, your total disk size is going to be large You can get the same organizational benefits with a single test binary and a bunch of modules like ```shell crates/datafusion/tests/integration.mod crates/datafusion/tests/integration/insert_into.rs ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
