austin362667 opened a new pull request, #12529: URL: https://github.com/apache/datafusion/pull/12529
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Partially closes #12311. ## Rationale for this change 1. We download IMDB queries from https://db.in.tum.de/~leis/qo/job.tgz and benchmark them with the helps of https://github.com/apache/datafusion/pull/12497. 2. Ensuring correctness by `imdb.slt`, just like what we did to `tpch.slt`. Unlike TPC-H, IMDB dataset is not generated and it's fixed sized, so no scaling factor and we don't need another docker container to generate data and answers. I cross-checked answers in csv files from https://github.com/duckdb/duckdb/tree/main/benchmark/imdb/answers . ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> IMDB(JOB) queries don't have incremental `query_id`, so I hard-coded the benchmark runner `query_id` (1,2,3,4, ... 113 in integer) to actual IMDB query name (1a, 1b, 1c, 1d, 2a, ... 33c in string, there is no pattern) mapping via lots of `if`. Currently, I've only add SLT for: - [X] 1a, 1b, 1c, 1d - [ ] 2a, 2b, 2c, 2d - [ ] 3a, 3b, 3c - [ ] 4a, 4b, 4c - [ ] 5a, 5b, 5c - [ ] 6a, 6b, 6c, 6d, 6e, 6f - [ ] ... - [ ] 33a, 33b, 33c ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> Yes, please check `test_files/imdb` for detail. <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
