smaheshwar-pltr commented on code in PR #121:
URL: 
https://github.com/apache/datafusion-iceberg/pull/121#discussion_r4628819574


##########
crates/datafusion/tests/insert_into.rs:
##########
@@ -489,3 +491,147 @@ async fn test_insert_into_partitioned() -> Result<(), 
Box<dyn Error>> {
 
     Ok(())
 }
+
+#[tokio::test]
+async fn test_insert_into_object_storage_layout_with_partition_paths()
+-> Result<(), Box<dyn Error>> {
+    let fixtures = FixtureCatalog::try_new().await?;
+    let ctx = create_category_table(
+        &fixtures,
+        &[(
+            TableProperties::PROPERTY_WRITE_OBJECT_STORAGE_ENABLED,
+            "true",
+        )],
+    )
+    .await?;
+
+    ctx.sql("INSERT INTO catalog.ns.t VALUES (1, 'a')")
+        .await?
+        .collect()
+        .await?;
+
+    assert_eq!(
+        redacted_data_file_paths(&fixtures).await?,

Review Comment:
   With https://github.com/apache/iceberg-rust/pull/3730, we could rely on 
Iceberg Rust behaviour and instead here just check that the file path matches 
what `ObjectStorageLocationGenerator` would yield by using it directly. I 
thought that being more explicit in the actual paths we expect might be nicer 
hence gone with this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to