NoahKusaba commented on PR #117: URL: https://github.com/apache/datafusion-iceberg/pull/117#issuecomment-7009946258
> > [@Perseus](https://github.com/Perseus) could you review this one? as (I think) you are more or less familiar with iceberg->df expression conversion > > Yes, happy to have a look later today. I took a cursory glance just now and a lot of it seems similar to the physical predicate converter that I've been working on [here](https://github.com/datafusion-contrib/datafusion-distributed/pull/869/changes#diff-030bea84a15071d9d7073cf3c542b4acc9175e6625f30a76eab0434ea5e0bdf4) . I removed a bunch of changes in my last commit to simplify the PR, but I had more-or-less the [same structure](https://github.com/datafusion-contrib/datafusion-distributed/pull/869/changes/249fd05a8060d25de9b5249ff30ba8ecfa2d1dda#diff-030bea84a15071d9d7073cf3c542b4acc9175e6625f30a76eab0434ea5e0bdf4) for exact vs inexact filters. Wasn't aware of your work in this area :smile: , really excited to see a resolution on https://github.com/apache/iceberg-rust/issues/3675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
