bit2swaz commented on issue #27543:
URL: https://github.com/apache/datafusion/issues/27543#issuecomment-7014014611

   @jayshrivastava that line is from 55.3. on main, 
[`reset()`](https://github.com/apache/datafusion/blob/6fb2913129ed031366255808eff859aa52672f49/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs#L377-L383)
 updates the shared filter in place (#26669) so the scan gets reset too
   
   i checked this with a hash join into parquet, and after `reset_plan_states` 
the scan shows `DynamicFilter [ true ]` and the decoded plan returns the right 
rows
   
   @adriangb completely valid and i agree, encoding stays as is
   
   so do you guys want a PR with a doc note on `reset_plan_states` + a proto 
test pinning it or should we just close this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to