sunchao commented on PR #25584: URL: https://github.com/apache/datafusion/pull/25584#issuecomment-7018289776
Reviewed `3e676a9640cbf68f99a705c5b341a5b71a49293a` with five independent reviewers covering correctness, performance/resources, design/reuse, tests, and documentation/API compatibility. No new actionable findings. Checked comparison normalization and NULL semantics, partial scans retaining the buffered group, summary reuse across outer batches, spill fallback, persistent admission refusal, and exhausted-key/cancellation cleanup. The SQL matrix and physical tests cover these boundaries using the existing join and memory-test infrastructure. The [exact-head fork Rust workflow](https://github.com/sunchao/arrow-datafusion/actions/runs/42869635175) passed all 27 executed jobs, including AMD64 tests, SQL logic tests, Clippy and benchmark-result verification; macOS was skipped. No local tests or benchmarks were run. Posting this as a conversation comment because this is my PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
