mbutrovich commented on PR #26593:
URL: https://github.com/apache/datafusion/pull/26593#issuecomment-7020099205

   > Since bounds are permanent once they ship, could we measure that cost 
before settling on them?
   
   @avantgardnerio's reply in 
https://github.com/apache/datafusion/pull/26593#issuecomment-6639300308 changes 
what bounds are for. They put a task's key range in the plan where a rule can 
use it, and the empty-partition alternative would need a separate API to say 
the same thing. With that argument, I no longer need the measurement.
   
   Could you add a few sentences to the PR description on why bounds instead of 
empty partitions? The description becomes the commit message, and that's where 
someone will look when #25483 or #27106 has to define how bounds compose.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to