comphead commented on code in PR #7687:
URL: https://github.com/apache/datafusion-comet/pull/7687#discussion_r4634474317
##########
native/spark-expr/src/hash_funcs/xxhash64.rs:
##########
@@ -237,6 +237,25 @@ mod tests {
test_hashes_with_nulls!(create_xxhash64_hashes, T, values, expected,
u64);
}
+ #[test]
+ fn test_hashes_buffer_length_mismatch_is_error() {
Review Comment:
The check lives in the shared `create_hashes_internal!`, so this test and
the one in `murmur3.rs` run the same code.
`test_non_canonical_nan_hashes_like_canonical_nan` in `murmur3.rs` already
checks both hashers in one test because they expand the same macros. Doing the
same here would keep `murmur3::tests` private and drop `length_mismatch_arrays`
as a cross-module helper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]