mbutrovich commented on PR #26507: URL: https://github.com/apache/datafusion/pull/26507#issuecomment-7021479588
Thanks @neilconway. Since this PR was opened, `datafusion-spark` moved to apache/datafusion-spark, and @alamb agreed the counter belongs in arrow-rs. I filed apache/arrow-rs#12346 to add `SetBitCounter` to `arrow-buffer`, and the PR for it is linked there. That version takes the bitmap instead of a word iterator, and it defines decreasing positions instead of looping. Once DataFusion is on an arrow release that has it, I'll open a DataFusion PR that cherry-picks your benchmark and `functions-nested` commits, switches them to the arrow-rs type, and addresses the call-site feedback here. The Spark call sites go to apache/datafusion-spark after that. I'll close this PR in favor of those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
