ewoodbury commented on code in PR #2898:
URL:
https://github.com/apache/datafusion-ballista/pull/2898#discussion_r4635136466
##########
ballista/client/tests/null_aware.rs:
##########
@@ -79,23 +93,38 @@ mod null_aware {
// all. "prefer_hash_join" and "aqe" exercise the rewrite under the
// hash-join planning paths. "rewrite_disabled" turns the rewrite off
// with hash joins preferred, covering the fallback path where the
- // null-aware join survives and is lowered to a single task.
- for variant in ["default", "prefer_hash_join", "aqe",
"rewrite_disabled"] {
+ // null-aware join survives and is lowered to a single task, under the
+ // default adaptive planner; "rewrite_disabled_static" does the same
+ // under the static planner. Both run one partition per task, as on a
+ // cluster.
+ for variant in [
Review Comment:
Yeah definitely - pushed up a quick test covering pipelined mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]