mbutrovich commented on PR #7690: URL: https://github.com/apache/datafusion-comet/pull/7690#issuecomment-7023504108
> The `i32` case doesn't need an arrow-rs release. Is that planned as a follow-up? The `i32` divisor landed in arrow-rs as `DivisorI32` (apache/arrow-rs#11467), so `pmod` will switch to it once Comet upgrades to an arrow release that includes it. We won't port it into Comet first, so Comet and arrow-rs keep one implementation. #7697 tracks it, along with the other Comet loops that divide by a fixed divisor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
