gabotechs commented on code in PR #128:
URL: 
https://github.com/apache/datafusion-iceberg/pull/128#discussion_r4641589670


##########
crates/datafusion/src/read/file_scan_task_provider/eager.rs:
##########
@@ -70,7 +71,7 @@ impl FileScanTaskProvider for EagerFileScanTaskProvider {
         self: Arc<Self>,
         partition: usize,
         _context: FileScanTaskProviderContext,
-    ) -> Result<iceberg::scan::FileScanTaskStream> {
+    ) -> Result<BoxStream<'static, Result<FileScanTask>>> {

Review Comment:
   The issue with `FileScanTaskStream` is that the errors returned in the 
messages are `iceberg::Error`s, not DataFusion errors. I did not notice in our 
past work, but the API here should probably be full DataFusion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to