andygrove commented on PR #27530: URL: https://github.com/apache/datafusion/pull/27530#issuecomment-7040635487
Thanks @comphead. All inline points are addressed in dd8ecf487, along with the `group_rows_range` visibility nit. Concurrent builds: I added a paragraph to the `group_rows` doc. It says that while grouping, the reservation holds both the chain and the groups. Afterwards it holds one more index per distinct key, so sibling partitions sharing the pool can find less memory than on main. I'd rather not guess a headroom margin without a case that shows the failure. Happy to add one if you have a figure in mind. Skew in `CollectLeft`: agreed, this belongs in a follow-up. I'll open an issue for the hot-key case, with your idea of keeping single-row keys in the map behind a tag bit, and link it from the PR body. The `hj` hot-key query from #27528 gives it a baseline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
