andygrove commented on code in PR #76:
URL: https://github.com/apache/datafusion-spark/pull/76#discussion_r4644390759
##########
crates/sqllogictest/test_files/string/format_string.slt:
##########
@@ -868,97 +868,97 @@ Upper: NULL
## NULL argument with string format
query T
-SELECT format_string('Value: %s', arrow_cast(NULL, 'Utf8View'));
+SELECT format_string('Value: %s', NULL::STRING);
----
Value: null
## NULL with string format (uppercase)
query T
-SELECT format_string('Upper: %S', arrow_cast(NULL, 'Utf8View'));
+SELECT format_string('Upper: %S', NULL::STRING);
----
Upper: NULL
## NULL with integer format using arrow_cast
query T
-SELECT format_string('Integer: %d', arrow_cast(NULL, 'Int32'));
+SELECT format_string('Integer: %d', NULL::INT);
Review Comment:
Small correction to my last comment. Besides the commented-out `Float16`
query, the 10 `Timestamp(ns)` queries at lines 995-1043 also keep "using
arrow_cast" in their headings, since they still call `arrow_cast` (there is no
SQL type for a nanosecond timestamp).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]