ozankabak commented on code in PR #12531:
URL: https://github.com/apache/datafusion/pull/12531#discussion_r1767011103
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -595,27 +650,17 @@ fn join_left_and_right_batch(
column_indices: &[ColumnIndex],
schema: &Schema,
visited_left_side: &SharedBitmapBuilder,
+ indices_cache: &mut (UInt64Array, UInt32Array),
) -> Result<RecordBatch> {
- let indices = (0..right_batch.num_rows())
- .map(|right_row_index| {
- build_join_indices(right_row_index, left_batch, right_batch,
filter)
- })
- .collect::<Result<Vec<(UInt64Array, UInt32Array)>>>()
- .map_err(|e| {
- exec_datafusion_err!(
- "Fail to build join indices in NestedLoopJoinExec, error:{e}"
- )
- })?;
-
- let mut left_indices_builder: Vec<u64> = vec![];
- let mut right_indices_builder: Vec<u32> = vec![];
- for (left_side, right_side) in indices {
- left_indices_builder.extend(left_side.values());
- right_indices_builder.extend(right_side.values());
- }
+ let (left_side, right_side) =
+ build_join_indices(left_batch, right_batch, filter,
indices_cache).map_err(
+ |e| {
+ exec_datafusion_err!(
+ "Fail to build join indices in NestedLoopJoinExec,
error:{e}"
Review Comment:
```suggestion
exec_datafusion_err!(
"Fail to build join indices in NestedLoopJoinExec,
error: {e}"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
