comphead commented on code in PR #6734:
URL: https://github.com/apache/datafusion-comet/pull/6734#discussion_r4645584956


##########
docs/source/contributor-guide/ai_assisted_contributions.md:
##########
@@ -0,0 +1,82 @@
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# AI-Assisted Contributions
+
+Many Comet contributors use AI coding tools to write code, tests and 
documentation, and to help
+review pull requests. That is welcome. Comet follows Apache DataFusion's [AI 
Policy]. Read it first.
+It sets out that you are responsible for everything you submit, whichever tool 
helped you write it,
+and it covers AI dumps, replying to reviews in your own words, and editing AI 
review output before
+you post it. This page adds what is specific to Comet.
+
+In short, automated reviews can be helpful, but a pull request must always be 
approved by a human.
+
+## Writing Code with AI Tools
+
+On top of the AI Policy, a change to Comet has to meet these:
+
+- Test it against Spark. Comet has to return the same results as Spark, 
including for nulls,
+  overflow, ANSI mode and time zones, and code that looks right can still get 
those wrong. Test
+  those cases, and run the suites that your change affects. [Continuous 
Integration](ci.md)
+  explains which changes need which suites.
+- Read the diff the way a reviewer will. Remove comments that narrate how the 
change was developed,
+  tests that don't cover anything new, and edits unrelated to the change.
+- Make sure that your contribution can be licensed under the Apache License. 
The ASF's
+  [Generative Tooling Guidance] explains what that involves when a tool wrote 
part of it.

Review Comment:
   This bullet restates the fourth bullet of the DataFusion AI Policy that the 
page opens by deferring to (follow the ASF Generative Tooling Guidance and do 
not include undisclosed third-party or copyrighted material). The reply to the 
earlier thread said the points the policy already covers were removed, so this 
one looks like it should go too. If you want to keep it, it would help to state 
the Comet-specific part, since "explains what that involves" does not tell the 
reader anything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to