mbutrovich commented on PR #7691: URL: https://github.com/apache/datafusion-comet/pull/7691#issuecomment-7046273082
@comphead > do you think it would make sense having inDF the docker linux benches similar to proposed https://github.com/apache/arrow-rs/issues/12349 I don't think it would help on a Mac. Docker there runs a Linux VM on the same Apple cores, so the core, caches, and memory bandwidth are still the Mac's. I left the details in a review on apache/arrow-rs#12351: https://github.com/apache/arrow-rs/pull/12351#pullrequestreview-5996839722 What would help Comet is the benchmark bot, which only runs on apache/datafusion and apache/arrow-rs PRs today ([README](https://github.com/adriangb/datafusion-benchmarking/blob/60a1e0e024fecd0e49a50b5b9d1ce574c5be59e3/README.md?plain=1#L48)). Until then, this PR still needs the x86-64-v3 and Neoverse-N1 runs the description asks for before the threshold is final. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
