lakshaydevoo-arch commented on code in PR #27334:
URL: https://github.com/apache/datafusion/pull/27334#discussion_r4645705503


##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -8968,6 +8974,74 @@ mod tests {
         Ok(())
     }
 
+    /// The evaluated key arrays are reserved before the map is allocated: with
+    /// room for the inputs only, the first failing request is the keys.
+    #[rstest]
+    #[tokio::test]
+    async fn join_build_key_arrays_are_reserved_before_map(

Review Comment:
   added the test to specifically cover the reservation order. The existing 
test checks that the key memory is eventually accounted for, but it wouldn't 
catch the case where the map gets allocated before that happens. This test 
should catch that regression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to