itsjunetime commented on PR #11989: URL: https://github.com/apache/datafusion/pull/11989#issuecomment-2361812330
> What is the logical schema and physical schema you have (the error)? I'm getting issues where both schemas are equivalent except for the metadata on the fields. I think (correct me if I'm wrong) that field metadata doesn't actually need to be equivalent for the invariant that this error is trying to catch to be upheld. I think we could comfortably switch from directly comparing the schemas with `PartialEq` to using [`equivalent_names_and_types`](https://github.com/apache/datafusion/blob/98e5f64df37b7a3a70ce5018d0d4098d0bed6ddb/datafusion/common/src/dfschema.rs#L666) or something like that. I can file a ticket and reproducer/fix for this. I'm also seeing issues that don't propagate with this exact error (but rather complain that `count(*)` is a non-nullable column that contains null values), so once I've figured out more specifics for this issue I can file another ticket for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
