alamb commented on PR #12516: URL: https://github.com/apache/datafusion/pull/12516#issuecomment-2362009358
> The purpose of such a change would be so that TableProvider::insert_into could take an op: InsertOp argument instead of two boolean arguments for overwrite and replace_into . I think it makes it slightly more convenient for implementors of the insert_into method to match on an enum rather than checking two booleans. What do you think? I agree it would be a good change 👌 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
