andygrove commented on code in PR #6361:
URL: https://github.com/apache/datafusion-comet/pull/6361#discussion_r4654118669


##########
spark/src/test/scala/org/apache/spark/sql/comet/execution/shuffle/CometDiskBlockWriterSuite.scala:
##########
@@ -223,6 +227,65 @@ class CometDiskBlockWriterSuite extends AnyFunSuite {
     }
   }
 
+  private def newWriter(
+      file: File,
+      allocator: CometShuffleMemoryAllocatorTrait,
+      taskContext: TaskContextImpl,
+      conf: SparkConf): CometDiskBlockWriter = {
+    new CometDiskBlockWriter(
+      file,
+      allocator,
+      pageSize,
+      pageSize,
+      taskContext,
+      new UnsafeRowSerializer(1).newInstance(),
+      schema,
+      new ShuffleWriteMetrics,
+      conf,
+      false,
+      new JLinkedList[CometDiskBlockWriter]())

Review Comment:
   Inlined it like the other tests, so the helper and the 
`CometShuffleMemoryAllocatorTrait` import are gone (f202425f2a).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to