jayzhan211 commented on code in PR #27618:
URL: https://github.com/apache/datafusion/pull/27618#discussion_r4656494517


##########
datafusion/fuzz/tests/suites/float_zero/queries.rs:
##########
@@ -0,0 +1,218 @@
+// SPDX-License-Identifier: Apache-2.0
+// SPDX-FileCopyrightText: See the NOTICE file distributed with this work for 
additional information regarding copyright ownership
+// SPDX-FileContributor: Licensed to the Apache Software Foundation (ASF) 
under one or more contributor license agreements
+
+//! The queries, and when each is known to give a wrong result.
+
+use super::settings::Setting;
+
+/// A query. `{t}` is replaced by the table name and `{z}` by a zero.
+#[derive(Debug)]
+pub struct Query {
+    pub name: &'static str,
+    pub sql: &'static str,
+    /// Whether the ORDER BY fixes the order of every row. If not, rows are
+    /// compared in any order.
+    pub ordered: bool,
+    pub known_failure: Option<KnownFailure>,
+}
+
+/// When a query is known to give a wrong result. Remove it when the bug is
+/// fixed; the fixed-table test fails until then.

Review Comment:
   Optional cleanup: this suite runs only in the merge queue, not on PR CI, so 
a PR that fixes one of these bugs only sees "remove its known failure" after it 
is dropped from the queue. Naming the local command here would let fix PRs 
catch it first; the fixed-table test takes under a second.
   
   ```suggestion
   /// When a query is known to give a wrong result. Remove it when the bug is
   /// fixed; the fixed-table test fails until then. This suite runs only in the
   /// merge queue, so a PR that fixes one of these bugs should run
   /// `cargo test -p datafusion-fuzz --features extended_tests --test fuzz 
float_zero_fixed`.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to