alamb commented on issue #12542: URL: https://github.com/apache/datafusion/issues/12542#issuecomment-2363877930
> I think the right fix in that case is 1, adding support for nested schemas. I agree this sounds like it makes sense. There even seems to be an existing ticket: #7647 Note that there is a PR by @jayzhan211 to rework how grouping is done to avoid the RowConverter in many cases in https://github.com/apache/datafusion/pull/12269. I haven't reivewed it thoroughly, but I would suggest that you ensure your fix for this issue is well covered by end to end `.slt` tests (not just unit tests) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
