Re: [PR] WIP: Account for constant equivalence properties in union, tests [datafusion]

[via GitHub]

alamb commented on code in PR #12562:
URL: https://github.com/apache/datafusion/pull/12562#discussion_r1769323644


##########
datafusion/physical-expr/src/equivalence/properties.rs:
##########
@@ -2617,379 +2633,356 @@ mod tests {
         ))
     }
 
-    #[tokio::test]
-    async fn test_union_equivalence_properties_multi_children() -> Result<()> {
-        let schema = create_test_schema()?;
+    #[test]
+    fn test_union_equivalence_properties_multi_children_1() {
+        let schema = create_test_schema().unwrap();
         let schema2 = append_fields(&schema, "1");
         let schema3 = append_fields(&schema, "2");
-        let test_cases = vec![
-            // --------- TEST CASE 1 ----------
-            (
+        UnionEquivalenceTest::new(&schema)

Review Comment:
   I wanted more flexibility with the tests, and I am glad I did this as I 
hadn't seen the existing tests for constants



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org