alamb commented on code in PR #12564:
URL: https://github.com/apache/datafusion/pull/12564#discussion_r1769534737
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -225,7 +225,12 @@ impl DataFrame {
/// # async fn main() -> Result<()> {
/// let ctx = SessionContext::new();
/// let df = ctx.read_csv("tests/data/example.csv",
CsvReadOptions::new()).await?;
- /// let df = df.select_columns(&["a", "b"])?;
+ /// df.select_columns(&["a", "b"])?.show().await?;
Review Comment:
What would you think about using [`assert_batches_eq`
](https://docs.rs/datafusion/latest/datafusion/macro.assert_batches_eq.html)instead
so that the output is automatically checked as part of the doc tests rather
than relying on us manually keeping it up to date?
It is of similar readability I think. Here is an example:
https://github.com/apache/datafusion/blob/d9cb6e677ec437a9c6ff2cc0900f902804da39bb/datafusion/core/tests/sql/select.rs#L27-L49
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
