OussamaSaoudi commented on code in PR #12578:
URL: https://github.com/apache/datafusion/pull/12578#discussion_r1770019432
##########
datafusion/core/src/execution/session_state.rs:
##########
@@ -1229,6 +1231,41 @@ impl SessionStateBuilder {
self
}
+ /// Register an `ObjectStore` to the [`RuntimeEnv`]. See
[`RuntimeEnv::register_object_store`]
+ /// for more details.
+ ///
+ /// Note that this creates a default [`RuntimeEnv`] if there isn't one
passed in already.
+ ///
+ /// ```
+ /// # use datafusion::prelude::*;
+ /// # use datafusion::execution::session_state::SessionStateBuilder;
+ /// # use datafusion_execution::runtime_env::RuntimeEnv;
+ /// # use url::Url;
+ /// # use std::sync::Arc;
+ /// # let http_store = object_store::local::LocalFileSystem::new();
+ /// let url = Url::try_from("file://").unwrap();
+ /// let object_store = object_store::local::LocalFileSystem::new();
+ /// let state = SessionStateBuilder::new()
+ /// .with_config(SessionConfig::new())
+ /// .with_object_store(&url, Arc::new(object_store))
+ /// .with_default_features()
+ /// .build();
+ /// ```
+ pub fn with_object_store(
+ mut self,
+ url: &Url,
+ object_store: Arc<dyn ObjectStore>,
+ ) -> Self {
+ if self.runtime_env.is_none() {
Review Comment:
The issue #12553 proposes creating a method `runtime_env` to set the default
and return a reference as the author does
[here](https://github.com/datafusion-contrib/datafusion-dft/blob/main/src/extensions/builder.rs#L102-L107).
However, there already is a method `runtime_env` and its signature doesn't
mesh well with that proposal. Currently I set a default runtime in
`with_object_store` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
