berkaysynnada commented on code in PR #12583: URL: https://github.com/apache/datafusion/pull/12583#discussion_r1770904821
########## datafusion/physical-expr-common/src/sort_expr.rs: ########## @@ -264,9 +267,55 @@ pub type LexOrdering = Vec<PhysicalSortExpr>; /// a reference to a lexicographical ordering. pub type LexOrderingRef<'a> = &'a [PhysicalSortExpr]; Review Comment: Perhaps we could follow a similar pattern for `LexOrderingRef`, too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
