brancz opened a new pull request, #12586: URL: https://github.com/apache/datafusion/pull/12586
## Which issue does this PR close? Closes https://github.com/apache/datafusion/issues/12542 ## Rationale for this change Non-nested arrays were already being dictionary encoded again if the input was dictionary encoded, so this just replicates that behavior for structs and lists. ## What changes are included in this PR? 1) Check whether there are any nested dictionaries to encode. 2) Encode arrays that have nested dictionaries appropriately. Note this may not be conclusive, I've only included lists and structs since those are the cases/types that I need and that I'm most familiar with. I think it'd be nice to get these changes in though and handle any further cases in separate PRs. ## Are these changes tested? Yes, added a unit test that tests precisely the scenario that led me to opening the issue. ## Are there any user-facing changes? No, only a bug fix. If the queries didn't panic before it could have been a change in behavior, but since all queries of this sort panicked before it's purely a bug fix. @alamb @tustvold @andygrove -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
