samuelcolvin opened a new pull request, #12588: URL: https://github.com/apache/datafusion/pull/12588
## Rationale for this change It's very frustrating when working on datafusion that unused imports cause scripts and tests to fail at build time, and not run. Also, while looking in to this, it seems the `pre-commit.sh` script wasn't failing when clippy failed. This doesn't affect CI where unused imports will still cause failure I believe. ## What changes are included in this PR? * remove `unused_imports = "deny"` from the root `Cargo.toml`, so the default behaviour of warning occurs * make `pre-commit.sh` fail if clippy fails ## Are these changes tested? Manually, yes. ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
