Re: [PR] Add Docs and Examples and helper methods to `PhysicalSortExpr` [datafusion]

Mon, 23 Sep 2024 05:58:07 -0700 


alamb commented on code in PR #12589:
URL: https://github.com/apache/datafusion/pull/12589#discussion_r1771353687


##########
datafusion/core/src/datasource/listing/table.rs:
##########
@@ -1238,20 +1238,13 @@ mod tests {
                     col("int_col").sort(false, true),
                 ]],
                 Ok(vec![vec![
-                    PhysicalSortExpr {
-                        expr: physical_col("string_col", &schema).unwrap(),
-                        options: SortOptions {
-                            descending: false,
-                            nulls_first: false,
-                        },
-                    },
-                    PhysicalSortExpr {
-                        expr: physical_col("int_col", &schema).unwrap(),
-                        options: SortOptions {
-                            descending: true,
-                            nulls_first: true,
-                        },
-                    },
+                    PhysicalSortExpr::new_default(physical_col("string_col", 
&schema).unwrap())

Review Comment:
   This shows what I would like to be able to do



##########
datafusion/physical-expr-common/src/sort_expr.rs:
##########
@@ -30,6 +30,51 @@ use datafusion_common::Result;
 use datafusion_expr_common::columnar_value::ColumnarValue;
 
 /// Represents Sort operation for a column in a RecordBatch
+///
+/// Example:

Review Comment:
   This looks like a massive example but it renders neatly I think:
   
   ![Screenshot 2024-09-23 at 8 56 58 
AM](https://github.com/user-attachments/assets/fd982ed2-5f62-400a-b89d-166d922a6c54)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to