viirya commented on code in PR #733:
URL: https://github.com/apache/datafusion-comet/pull/733#discussion_r1771896989
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1692,16 +1692,33 @@ impl PhysicalPlanner {
.and_then(|inner| inner.lower_frame_bound_struct.as_ref())
{
Some(l) => match l {
- LowerFrameBoundStruct::UnboundedPreceding(_) => {
- WindowFrameBound::Preceding(ScalarValue::UInt64(None))
- }
+ LowerFrameBoundStruct::UnboundedPreceding(_) => match units {
+ WindowFrameUnits::Rows => {
+ WindowFrameBound::Preceding(ScalarValue::UInt64(None))
+ }
+ WindowFrameUnits::Range | WindowFrameUnits::Groups => {
Review Comment:
Can we add it as separate pattern branch and return error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
