Rachelint commented on issue #11680: URL: https://github.com/apache/datafusion/issues/11680#issuecomment-2369243045
> > But I think we should push this forward after: > > I agree -- thank you for all this POC work @Rachelint -- very cool. > > I personally plan to > > 1. help @jayzhan211 get [Avoid RowConverter for multi column grouping #12269](https://github.com/apache/datafusion/pull/12269) over (and any cleanup / follow on work) -- 10-20% improvements > > 2. Get `StringView` on by default -- another 10-20% improvements > > > Then I will have bandwidth to consider the intermediate blocked management > > > Refactor the aggregation codes. I think it is getting unmaintainable... Some issues pointed out this too Improve aggregation code readability #12335 > > Yes, I think this is the biggest challenge at the moment. I actually view the fuzz tesing as a critical piece of this so as we rearrange the code we have confidence we aren't introducing regressions > > Thank you again for all your help so far Yes, I agree testing is extremely important before introducing further big changes to aggregation codes. I am also researching and thinking how to refine the exists fuzz tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
