Eason0729 commented on issue #12518: URL: https://github.com/apache/datafusion/issues/12518#issuecomment-2369962179
There is a private method `parse_expr_with_alias` in sqlparser, which returns `ExprWithAlias`. I would propose changing the return type from `sqlparser::ast::Expr` on call path to `sqlparser::ast::ExprWithAlias`, use enum `datafusion_expr::expr::Expr::Alias` in return type. > Writing a example change might be better if more description in needed This could cause other method to change(including some public methods on SessionState). If above is okay, I would begin working on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
