jayzhan211 commented on issue #12604: URL: https://github.com/apache/datafusion/issues/12604#issuecomment-2371421364
I think `select_to_plan` is actually `datafusion's internal AST layer that convert sqlparser AST to LogicalPlan`, can you explain more what is the difference between them? I don't get it why carrying type explicitly in `Expr` could improve the performance. If `get_type` is slow, we also has the same cost of find the type when creating Expr along with the type, isn't it? If the computing of type is expensive, we could consider caching the result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
