andygrove commented on code in PR #1059: URL: https://github.com/apache/datafusion-ballista/pull/1059#discussion_r1775211407
########## ballista/scheduler/src/scheduler_server/grpc.rs: ########## @@ -70,7 +72,10 @@ impl<T: 'static + AsLogicalPlan, U: 'static + AsExecutionPlan> SchedulerGrpc "Bad request because poll work is not supported for push-based task scheduling", )); } - let remote_addr = request.remote_addr(); + let remote_addr = request + .extensions() + .get::<ConnectInfo<SocketAddr>>() + .cloned(); Review Comment: nit: this code block is repeated a few times so it may be worth extracting into a method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org