alamb opened a new pull request, #12623: URL: https://github.com/apache/datafusion/pull/12623
## Which issue does this PR close? Follow on to https://github.com/apache/datafusion/pull/12269 from @jayzhan211 ## Rationale for this change The initial implementation of the Column-wise group checking code uses `Vec<bool>` to track null/validity but Arrow has a variety of optimized structures for doing so (`BooleanBufferBuilder`, etc) I would like to get this code into great shape before we fill out support for other data types (like StringView and BinaryView) I also feel like `PrimitiveGroupValueBuilder` could largely be a wrapper around PrimitiveBuilder in arrow which would avoid the code duplication as well as take advantage of Arrow's optimizations Let's use BooleanBufferBuilder to simplify the null handling in PrimitiveGroupValueBuilder. I ## What changes are included in this PR? Rewrite `PrimitiveGroupValueBuilder` ## Are these changes tested? By existing CI ## Are there any user-facing changes? No Performance results (RUNNING) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
