goldmedal commented on code in PR #12621:
URL: https://github.com/apache/datafusion/pull/12621#discussion_r1775454456
##########
datafusion/sqllogictest/src/engines/datafusion_engine/normalize.rs:
##########
@@ -198,12 +198,16 @@ macro_rules! get_row_value {
///
/// Floating numbers are rounded to have a consistent representation with the
Postgres runner.
///
-pub fn cell_to_string(col: &ArrayRef, row: usize) -> Result<String> {
+pub fn cell_to_string(
+ col: &ArrayRef,
+ row: usize,
+ data_type: &DataType,
Review Comment:
oops... my bad. It's my other experimental change. I forgot to roll back it.
I'll recover it. Thanks for mentioning it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
