andygrove commented on code in PR #12626:
URL: https://github.com/apache/datafusion/pull/12626#discussion_r1775552730
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -490,7 +490,14 @@ impl AsLogicalPlan for LogicalPlanNode {
into_logical_plan!(sort.input, ctx, extension_codec)?;
let sort_expr: Vec<SortExpr> =
from_proto::parse_sorts(&sort.expr, ctx, extension_codec)?;
- LogicalPlanBuilder::from(input).sort(sort_expr)?.build()
+ let fetch: usize = sort.fetch.try_into().map_err(|_| {
+ DataFusionError::Internal(String::from(
+ "Protobuf deserialization error, invalid limit value'",
Review Comment:
It would be good to show the invalid value and/or the error message to ease
debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
