eejbyfeldt commented on code in PR #12571:
URL: https://github.com/apache/datafusion/pull/12571#discussion_r1775739801
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -137,6 +141,10 @@ pub struct PhysicalGroupBy {
/// expression in null_expr. If `groups[i][j]` is true, then the
/// j-th expression in the i-th group is NULL, otherwise it is `expr[j]`.
groups: Vec<Vec<bool>>,
+ // The number of internal expressions that are used to implement grouping
+ // sets. These output are removed from the final output and not in `expr`
+ // as they are generated based on the value in `groups`
+ num_internal_exprs: usize,
Review Comment:
Currently not. My thinking was that in the future we might add more internal
exprs to also solve (https://github.com/apache/datafusion/issues/5672) and or
support more than 64 grouping columns (if someone ever needs that). As I think
was done in https://github.com/apache/datafusion/pull/5749
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
